Hi Kmcnet,
Thank you for reaching out to Microsoft Q & A forum.
If the class library is primarily used within a single application, or if you're actively developing it alongside the application, it's generally best to include it as a project within the same Visual Studio solution. This makes development, debugging, and maintenance more convenient.
On the other hand, if the library is intended to be reused across multiple solutions or applications, keeping it in a separate solution and referencing it or packaging it as a NuGet package is a better practice. This allows for version control and reuse without tightly coupling it to a specific project.
In short, your current approach isn't incorrect, it just depends on how the library is intended to be used and maintained over time.
If you have found the answer provided to be helpful, please click on the "Accept answer/Upvote" button so that it is useful for other members in the Microsoft Q&A community.